feat: Adding efficiency vs production radius to output root files (Revision of PR #3539) #3981
Conversation
WalkthroughEnhancements to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
Examples/Io/Root/src/RootTrackSummaryWriter.cpp (1)
115-115: Consistent with the codebase patterns, your changes are!Follow the established patterns for branch creation, variable initialization, computation, and vector operations, your implementation does. Harmoniously integrated with existing code structure, these changes are.
Consider documenting the physical meaning of production radius in a comment, help future maintainers it will.
Also applies to: 303-303, 344-344, 396-396, 582-582
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
Examples/Framework/include/ActsExamples/Validation/EffPlotTool.hpp(2 hunks)Examples/Framework/src/Validation/EffPlotTool.cpp(5 hunks)Examples/Io/Root/src/RootTrackSummaryWriter.cpp(5 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- Examples/Framework/include/ActsExamples/Validation/EffPlotTool.hpp
- Examples/Framework/src/Validation/EffPlotTool.cpp
🔇 Additional comments (1)
Examples/Io/Root/src/RootTrackSummaryWriter.cpp (1)
344-344: Correct, the calculation of production radius is!
Using Euclidean distance in XY plane, proper it is. Clear and efficient implementation, you have created.
|
Output changes are expected, the references will need to be updated. |
github-actions
bot
added
Infrastructure
|
Ah, one thing I realized just now is that the auto-plotter currently does not get a fixed range configured in Could you fix the range to some empirical value so that it includes a reasonable range in R? |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CI/physmon/config/tracksummary_ckf.yml(1 hunks)Examples/Python/tests/root_file_hashes.txt(3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- Examples/Python/tests/root_file_hashes.txt
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: linux_ubuntu_extra (ubuntu2204_clang, 20)
- GitHub Check: macos
- GitHub Check: linux_ubuntu_extra (ubuntu2204, 20)
- GitHub Check: linux_ubuntu
- GitHub Check: missing_includes
- GitHub Check: build_debug
🔇 Additional comments (1)
CI/physmon/config/tracksummary_ckf.yml (1)
168-172: Pleased with the structure, I am.Well-organized and consistent with other histogram configurations, this addition is. In harmony with the Force of YAML formatting, it stands.
|
|
@delitez I'm afraid at least one reference file was changed on |
This PR is the revised version of the work of @AichaMattouhi (#3539). Efficiency vs production radius plot is added to the performance and track summary root output files.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores